Include similarity in index settings #2924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Requires backporting to 2.x and 5.x in a non-binary breaking way |
russcam
force-pushed
the
fix/similarities
branch
from
5a1fd1a to
8d3fcae
Compare
Similarity settings are nested under settings>index Rename DefaultSimilarity to ClassicSimilarity Add DFISimilarity Add similarity settings to create index integration tests Add XML comments for each similarity Refactor SimilarityJsonConverter to not look up the NEST ISimilarity type with Type.GetType() but to infer it from the type property value directly. Add Similarity to the updatable index settings Closes #2890
Mpdreamz
force-pushed
the
fix/similarities
branch
from
8d3fcae to
5ca1c11
Compare
russcam
added a commit
that referenced
this pull request
Dec 15, 2017
Non binary breaking back port of 648c3cf Similarity settings are nested under settings>index Add ClassicSimilarity Add DFISimilarity Add similarity settings to create index integration tests Add XML comments for each similarity Refactor SimilarityJsonConverter to not look up the NEST ISimilarity type with Type.GetType() but to infer it from the type property value directly. Add Similarity to the updatable index settings Closes #2890
russcam
added a commit
that referenced
this pull request
Dec 18, 2017
Non binary breaking back port of 648c3cf Similarity settings are nested under settings>index Add ClassicSimilarity Add DFISimilarity Add similarity settings to create index integration tests Add XML comments for each similarity Refactor SimilarityJsonConverter to not look up the NEST ISimilarity type with Type.GetType() but to infer it from the type property value directly. Add Similarity to the updatable index settings Closes #2890
russcam
added a commit
that referenced
this pull request
Dec 18, 2017
Non binary breaking back port of 648c3cf Similarity settings are nested under settings>index Add ClassicSimilarity Add DFISimilarity Add similarity settings to create index integration tests Add XML comments for each similarity Refactor SimilarityJsonConverter to not look up the NEST ISimilarity type with Type.GetType() but to infer it from the type property value directly. Add Similarity to the updatable index settings Closes #2890 (cherry picked from commit bf78582)
russcam
added a commit
that referenced
this pull request
Jan 15, 2018
Non binary breaking back port of 648c3cf Similarity settings are nested under settings>index Add ClassicSimilarity Add DFISimilarity Add similarity settings to create index integration tests Add XML comments for each similarity Refactor SimilarityJsonConverter to not look up the NEST ISimilarity type with Type.GetType() but to infer it from the type property value directly. Add Similarity to the updatable index settings Closes #2890 (cherry picked from commit bf78582)
russcam
added a commit
that referenced
this pull request
Jan 15, 2018
Non binary breaking back port of 648c3cf Similarity settings are nested under settings>index Add ClassicSimilarity Add DFISimilarity Add similarity settings to create index integration tests Add XML comments for each similarity Refactor SimilarityJsonConverter to not look up the NEST ISimilarity type with Type.GetType() but to infer it from the type property value directly. Add Similarity to the updatable index settings Closes #2890 (cherry picked from commit bf78582)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarity settings are nested under settings>index
Rename DefaultSimilarity to ClassicSimilarity
Add DFISimilarity
Add similarity settings to create index integration tests
Add XML comments for each similarity
Refactor SimilarityJsonConverter to not look up the NEST ISimilarity type with Type.GetType() but to infer it from the type property value directly.
Add Similarity to the updatable index settings
Closes #2890