Use serializer when deserializing LazyDocument to T #2791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
approved these changes
Jun 27, 2017
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
LgTM with one q? Maybe add a comment there explaining why we need to write null?
| var d = value as LazyDocument; | ||
| if (d?._Value == null) | ||
| { | ||
| writer.WriteNull(); |
Contributor
Author
There was a problem hiding this comment.
I think this is an oversight in the implementation; if d is null or d.Value is null and a value is not written to the writer for it, invalid json can be emitted e.g. if LazyDocument is assigned to the property of an object and that object serialized, the property name could be written to the writer (depending on serialization settings) so a value must also be written in this case
Member
|
Can we also add an ovlerload to fix #2408 as part of this PR. Two for one :) |
Contributor
Author
Member
|
Also a |
Contributor
Author
|
Gotcha |
When converting a LazyDocument to type T, use the JsonNetSerializer configured, along with all registered contract resolvers. Fixes #2788
Contributor
Author
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
* Use serializer when deserializing LazyDocument to T When converting a LazyDocument to type T, use the JsonNetSerializer configured, along with all registered contract resolvers. Fixes elastic#2788 * Direct cast * Add non-generic overload for As() Relates elastic#2408 (cherry picked from commit 109bcb0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting a LazyDocument to type T, use the JsonNetSerializer configured, along with all registered contract resolvers.
Fixes #2788