Throw an exception when Reindex() produces just enough documents for … #2781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
approved these changes
Jun 19, 2017
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
LGTM - one very minor nitpick 😄
|
|
||
| var funnelExact = producerBandwidth == bulkSize; | ||
| if (funnelExact) | ||
| throw new Exception("The back pressure settings are too conservative it provides enough documents for a single bulk but not enough room to advance " |
Contributor
There was a problem hiding this comment.
minor pedantic punctuation nitpick:
The back pressure settings are too conservative. They provide enough documents for a single bulk but not enough room to advance ...
Mpdreamz
force-pushed
the
fix/backpressure-reindex-exact
branch
from
2b98d44 to
292abd5
Compare
…a single bulk but leaves no slots to call MoveNext() which would free up an awaiting task. fixes #2771
…the producer to call MoveNext()
Mpdreamz
force-pushed
the
fix/backpressure-reindex-exact
branch
from
292abd5 to
1cdc825
Compare
Member
Author
|
Only needed to be backported to |
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
elastic#2781) * Throw an exception when Reindex() produces just enough documents for a single bulk but leaves no slots to call MoveNext() which would free up an awaiting task. fixes elastic#2771 * improved exception message when backpressure does not leave room for the producer to call MoveNext()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a single bulk but leaves no slots to call MoveNext() which would free up an awaiting task. fixes #2771