Adds test collections filtering #2470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> build integrate 5.0.0 readonly getindexapi Also fixes SkipMethod being too greedy ReadOnly cluster was only yielding 14 tests.
russcam
reviewed
Dec 7, 2016
| IF /I "%1%"=="integrate" ( | ||
| IF NOT [%2]==[] (set ESVERSIONS="%2") | ||
| IF NOT [%3]==[] (set NEST_INTEGRATION_CLUSTER="%3") | ||
| IF NOT [%4]==[] (set NEST_TEST_FILTER="%4") |
russcam
reviewed
Dec 8, 2016
| var classOfMethod = Type.GetType(testMethod.TestClass.Class.Name, true, true); | ||
| var method = classOfMethod.GetMethod(testMethod.Method.Name); | ||
| var collectionType = testMethod.TestClass?.TestCollection?.CollectionDefinition?.Name; | ||
| var method = classOfMethod.GetMethod(testMethod.Method.Name, BindingFlags.FlattenHierarchy | BindingFlags.NonPublic | BindingFlags.Public) |
Member
Author
|
I'm assuming by your comments this PR is ok @russcam, pulling it in because I need it on another branch 😄 |
Mpdreamz
added a commit
that referenced
this pull request
Dec 8, 2016
> build integrate 5.0.0 readonly getindexapi Also fixes SkipMethod being too greedy ReadOnly cluster was only yielding 14 tests.
Contributor
|
++ I needed it on two branches today 😄 |
Mpdreamz
added a commit
that referenced
this pull request
Dec 8, 2016
> build integrate 5.0.0 readonly getindexapi Also fixes SkipMethod being too greedy ReadOnly cluster was only yielding 14 tests. Conflicts: build/scripts/Targets.fsx src/Tests/Framework/Configuration/EnvironmentConfiguration.cs src/Tests/Framework/Configuration/ITestConfiguration.cs src/Tests/Framework/Configuration/NodeConfiguration.cs src/Tests/Framework/Configuration/TestConfigurationBase.cs src/Tests/Framework/Configuration/YamlConfiguration.cs src/Tests/Framework/XUnitPlumbing/IntegrationTestDiscoverer.cs src/Tests/Framework/XUnitPlumbing/NestTestDiscoverer.cs src/Tests/Framework/XUnitPlumbing/UnitTestDiscoverer.cs src/Tests/tests.yaml
Member
Author
|
ported to |
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
> build integrate 5.0.0 readonly getindexapi Also fixes SkipMethod being too greedy ReadOnly cluster was only yielding 14 tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes SkipMethod being too greedy ReadOnly cluster was only
yielding 14 tests.