Add type to set auto expand replicas #2459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
requested changes
Dec 6, 2016
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
Small nitpick looks good otherwise!
| } | ||
| } | ||
|
|
||
| public static AutoExpandReplicas Disabled() => new AutoExpandReplicas(); |
Member
There was a problem hiding this comment.
AutoExpandReplicas looks immutable to me so this could be a static property { get; } = new AutoExpandReplicas() so that single instance could be reused.
Contributor
Author
There was a problem hiding this comment.
++ I'll make it immutable and make the disabled instance static 👍
russcam
force-pushed
the
feature/5.x-autoexpandreplicas
branch
from
fb752f4 to
fef79e5
Compare
russcam
force-pushed
the
feature/5.x-autoexpandreplicas
branch
from
fef79e5 to
6e96617
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.