Faster enum -> string resolution #2418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specific enum GetStringValue extension methods for known enums Caching of generic method of resolving string values for enums based on enum type. Renamed KnownEnums.Resolve to GetStringValue and made an extension method. Added GetStringValue extension method for HttpMethod - this is a hot path, called on every request. Fixed casing issue in HttpConnection for setting ContentLength Closes #2400
Mpdreamz
approved these changes
Nov 28, 2016
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
LGTM 👍 should have done this from the start
Mpdreamz
pushed a commit
that referenced
this pull request
Nov 29, 2016
Specific enum GetStringValue extension methods for known enums Caching of generic method of resolving string values for enums based on enum type. Renamed KnownEnums.Resolve to GetStringValue and made an extension method. Added GetStringValue extension method for HttpMethod - this is a hot path, called on every request. Fixed casing issue in HttpConnection for setting ContentLength Closes #2400 Conflicts: src/Elasticsearch.Net/Domain/Enums.Generated.cs
Mpdreamz
pushed a commit
that referenced
this pull request
Nov 29, 2016
Specific enum GetStringValue extension methods for known enums Caching of generic method of resolving string values for enums based on enum type. Renamed KnownEnums.Resolve to GetStringValue and made an extension method. Added GetStringValue extension method for HttpMethod - this is a hot path, called on every request. Fixed casing issue in HttpConnection for setting ContentLength Closes #2400 Conflicts: src/CodeGeneration/ApiGenerator/Views/Enums.Generated.cshtml src/Elasticsearch.Net/Domain/Enums.Generated.cs src/Elasticsearch.Net/Extensions/Extensions.cs src/Nest/Mapping/AttributeBased/ElasticsearchCorePropertyAttributeBase.cs src/Nest/Mapping/Types/Core/Number/NumberAttribute.cs
Member
|
ported to |
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
Specific enum GetStringValue extension methods for known enums Caching of generic method of resolving string values for enums based on enum type. Renamed KnownEnums.Resolve to GetStringValue and made an extension method. Added GetStringValue extension method for HttpMethod - this is a hot path, called on every request. Fixed casing issue in HttpConnection for setting ContentLength Closes elastic#2400 Conflicts: src/Elasticsearch.Net/Domain/Enums.Generated.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetStringValueextension methods for known enumsKnownEnums.ResolvetoGetStringValueand made an extension method. Allows enum specific overloads to be introduced where necessaryCloses #2400