Allow 404s for Get and Delete requests #2366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
reviewed
Nov 3, 2016
|
|
||
|
|
||
| ///<summary>A comma-separated list of stored fields to return as part of a hit</summary> | ||
| public DeleteByQueryRequestParameters StoredFields(params string[] stored_fields) => this.AddQueryString("stored_fields", stored_fields); |
Member
There was a problem hiding this comment.
We should probably make sure everything with *Fields gets generated as fields that take Fields and Expressions. Like other fields do too. New issue though.
Contributor
Author
There was a problem hiding this comment.
This is in Elasticsearch.Net though; Fields exists in NEST?
Mpdreamz
requested changes
Nov 3, 2016
|
|
||
| response.ShouldBeValid(); | ||
| response.Found.Should().BeFalse(); | ||
| response.Result.Should().Be(Result.NotFound); |
Member
There was a problem hiding this comment.
Assert .Index and the like as well
russcam
force-pushed
the
fix/5.x-allow404s
branch
from
299d9c9 to
a83eaf7
Compare
Mpdreamz
approved these changes
Nov 8, 2016
russcam
force-pushed
the
fix/5.x-allow404s
branch
from
a83eaf7 to
12fc3f2
Compare
Update Rest Api Specs to v5.0.0 Closes #2306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Rest Api Specs to v5.0.0
Closes #2306