Correctly handle 400 status code response #2310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a ReindexOnServerResponse comes back as 400 status code, deserialize the response so that Failures is populated with more details for why things failed. Use the -1 special case in AllowedStatusCodes in the dispatch call, similar to UpdateByQuery and DeleteByQuery; IsValid will still be false as it checks Failures which will be deserialized and not be empty. Success on ApiCallDetails will be true however. Closes #2309
Mpdreamz
approved these changes
Oct 10, 2016
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
LGTM.
FYI I opened this ticket on core repos couple months back to discuss this behavior:
Contributor
|
LGTM 👍 |
gmarz
pushed a commit
that referenced
this pull request
Oct 25, 2016
When a ReindexOnServerResponse comes back as 400 status code, deserialize the response so that Failures is populated with more details for why things failed. Use the -1 special case in AllowedStatusCodes in the dispatch call, similar to UpdateByQuery and DeleteByQuery; IsValid will still be false as it checks Failures which will be deserialized and not be empty. Success on ApiCallDetails will be true however. Closes #2309
gmarz
pushed a commit
that referenced
this pull request
Oct 25, 2016
When a ReindexOnServerResponse comes back as 400 status code, deserialize the response so that Failures is populated with more details for why things failed. Use the -1 special case in AllowedStatusCodes in the dispatch call, similar to UpdateByQuery and DeleteByQuery; IsValid will still be false as it checks Failures which will be deserialized and not be empty. Success on ApiCallDetails will be true however. Closes #2309
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
ReindexOnServerResponsecomes back as 400 status code, deserialize the response so thatFailuresis populated with more details for why things failed.Use the -1 special case in
AllowedStatusCodesin the dispatch call, similar toUpdateByQueryandDeleteByQuery;IsValidwill still be false as it checksFailureswhich will be deserialized and not be empty.SuccessonApiCallDetailswill be true however.Closes #2309