Expose constructor with inner aggregation dictionary #1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @mausch. This LGTM, but we should probably do this for all of the other aggregation response types that inherit from |
Contributor
Author
|
Sure, I only noticed it for this one because that's what I had to use in my test, but it should be same for other similar classes. |
gmarz
added a commit
that referenced
this pull request
Jan 22, 2015
Expose constructor with inner aggregation dictionary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I want to test a function that converts aggregation results into something else I need to set the inner aggregations of a
SingleBucketin order to set up the test data. This class however doesn't currently expose the constructors of its base classes so it's not possible.