Skip to content

Conversation

@ilivewithian
Copy link
Contributor

No description provided.

@Mpdreamz
Copy link
Member

Nice catch @ilivewithian and big sigh to us for letting this one slip.

Sadly we have to keep the typo'd version around with an obsolete attribute:

[Obsolete("Scheduled for removal in 2.0, this method name has a typo")]

This is so that we can maintain a strict backwards compatibility semver wise. We have to do this because we strong name our assemblies but in order to avoid binding redirects we only update the AssemblyFileVersion. This works great but means that code that depends on the typo'd version being in the dll could throw a nasty runtime exceptions if a later fixed 1.x dll ends up being loaded.

Is this something that you can amend this PR with? Also be sure to sign our CLA so that we may pull these bits in: http://www.elasticsearch.org/contributor-agreement/

@ilivewithian
Copy link
Contributor Author

Yeah, I did wonder if you'd want to keep the old version in some form. I'll update the PR later today.

@ilivewithian
Copy link
Contributor Author

That's updated, I squashed the change into a single commit, I didn't think you'd want two commits for such a tiny change.

Also, I've signed the CLA.

@gmarz gmarz added the v1.3.0 label Nov 24, 2014
@gmarz
Copy link
Contributor

gmarz commented Nov 24, 2014

Argh, nice find @ilivewithian and thanks for the PR. LGTM.

gmarz added a commit that referenced this pull request Nov 24, 2014
Corrected Typo In DeleteTemplateAsync Method Name
@gmarz gmarz merged commit f3e758f into elastic:develop Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants