Add connection setting to enable/disable HTTP pipelining #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM 👍 |
Mpdreamz
added a commit
that referenced
this pull request
Nov 6, 2014
Add connection setting to enable/disable HTTP pipelining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, pipelining was explicitly disabled since elasticsearch did not support it. Support has just been added (elastic/elasticsearch#8299) and so this PR adds a connection setting to enable/disable pipelining on the client as well.
Pipelining can be turned on at a global/connection level via
IConnectionConfigurationValuesor per request viaIRequestConfiguration. The default is to disable pipelining (might make sense to default to enabled in2.0).