Skip to content

Conversation

cotti
Copy link
Contributor

@cotti cotti commented Oct 9, 2025

This PR adds initial support for observability for the API Lambda.

It contains a few instrumentations, but further studies to define which set should be used will be done as well. AOT is preserved by disabling assembly scanning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the name of this file be appsettings.edge.json? (no capital)

Not a blocker: but do you see a way to configure this outside of the application.

E.g. We want to change it to DEBUG because we need to debug something in production.

Or is this already possible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use environment variables too - in this case control can be manual in the AWS web interface or through infra changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship logs too :)

@cotti cotti requested review from Mpdreamz and reakaleek October 14, 2025 12:45
cotti and others added 2 commits October 14, 2025 10:46
# Conflicts:
#	src/api/Elastic.Documentation.Api.Lambda/Program.cs
@cotti cotti marked this pull request as ready for review October 14, 2025 13:55
@cotti cotti requested a review from a team as a code owner October 14, 2025 13:55
@cotti cotti merged commit e935f61 into main Oct 14, 2025
20 checks passed
@cotti cotti deleted the feature/lambda_obs branch October 14, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants