-
Notifications
You must be signed in to change notification settings - Fork 31
Observability: Initial setup for the API Lambda #2028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can the name of this file be appsettings.edge.json
? (no capital)
Not a blocker: but do you see a way to configure this outside of the application.
E.g. We want to change it to DEBUG because we need to debug something in production.
Or is this already possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use environment variables too - in this case control can be manual in the AWS web interface or through infra changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship logs too :)
Co-authored-by: Martijn Laarman <[email protected]>
# Conflicts: # src/api/Elastic.Documentation.Api.Lambda/Program.cs
This PR adds initial support for observability for the API Lambda.
It contains a few instrumentations, but further studies to define which set should be used will be done as well. AOT is preserved by disabling assembly scanning.