Skip to content

Use marked in conjunction with hljs instead of EuiMarkdownFormat #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 10, 2025
Merged

Use marked in conjunction with hljs instead of EuiMarkdownFormat #2025

merged 13 commits into from
Oct 10, 2025

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Oct 9, 2025 •
edited
Loading

Changes

  • Remove EuiMarkdownFormat because it increases the js asset size significantly
  • Use marked in conjunction with hljs instead.
  • Fix code block copy functionality to make also work in AI message

Effect

  • The build size is smaller
  • The AI message is our styling.

Screenshots

Before After
image image
Before After
image image

@reakaleek reakaleek marked this pull request as ready for review October 9, 2025 09:34
@reakaleek reakaleek requested a review from a team as a code owner October 9, 2025 09:34
@reakaleek reakaleek requested a review from cotti October 9, 2025 09:34
cotti
cotti approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@cotti cotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@reakaleek reakaleek enabled auto-merge (squash) October 10, 2025 10:33
@reakaleek reakaleek merged commit b3b15c4 into main Oct 10, 2025
22 checks passed
@reakaleek reakaleek deleted the feature/optimimize-asset-size branch October 10, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cotti cotti cotti approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reakaleek @cotti