Making field optional as it may not always be present #12512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field was introduced in Elasticsearch 7.2.0. So it won't exist if Metricbeat is monitoring an older version of Elasticsearch. So we mark it as optional in the schema.
ycombinator
added
bug
module
review
Metricbeat
Contributor
|
Pinging @elastic/stack-monitoring |
ycombinator
added
the
needs_backport
cachedout
approved these changes
Jun 13, 2019
kaiyan-sheng
approved these changes
Jun 14, 2019
ycombinator
added a commit
that referenced
this pull request
Jun 14, 2019
ycombinator
removed
the
needs_backport
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…12512) (elastic#12541) This field was introduced in Elasticsearch 7.2.0. So it won't exist if Metricbeat is monitoring an older version of Elasticsearch. So we mark it as optional in the schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12511.
This field was introduced in Elasticsearch 7.2.0: elastic/elasticsearch#38643. So it won't exist if Metricbeat is monitoring an older version of Elasticsearch. So we mark it as optional in the schema.