Added Zero-configuration support section #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪 |
felixbarny
approved these changes
Sep 1, 2021
vigneshshanmugam
approved these changes
Sep 1, 2021
trentm
approved these changes
Sep 1, 2021
SylvainJuge
approved these changes
Sep 1, 2021
basepi
approved these changes
Sep 1, 2021
basepi
approved these changes
Sep 1, 2021
Contributor
basepi
left a comment
basepi
left a comment
There was a problem hiding this comment.
I made a pass at simplifying and clarifying the language a little bit. These are definitely nits, do with them as you will.
Co-authored-by: Trent Mick <[email protected]>
Co-authored-by: Colton Myers <[email protected]>
SergeyKleyman
commented
Sep 1, 2021
Comment on lines
+122
to
+125
| Agents should be able to auto-detect the APM Server endpoint | ||
| by just defaulting to `http://localhost:8200/`. | ||
| Furthermore, if it's possible, agents should detect sensible defaults for `service.name` | ||
| and `service.version`. |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| Agents should be able to auto-detect the APM Server endpoint | |
| by just defaulting to `http://localhost:8200/`. | |
| Furthermore, if it's possible, agents should detect sensible defaults for `service.name` | |
| and `service.version`. | |
| By default, agents should send data to the APM Server at `http://localhost:8200/`. | |
| If possible, agents should detect sensible defaults for `service.name` and `service.version`. | |
| Even if detecting these values is not possible, a default value for `service.name` should be provided for frictionless onboarding. |
WDYT about the suggestion above?
axw
approved these changes
Sep 2, 2021
This was referenced Dec 2, 2021
This was referenced Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #401