-
Notifications
You must be signed in to change notification settings - Fork 536
Docs: WIP V2/6.5 additions and changes #1530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c17bb5e
docs: rework apm overview
bmorelli25 39c7472
docs: move events and add distributed tracing
bmorelli25 c632c8c
docs: add more v2 and change layout
bmorelli25 d79b392
docs: more v2 additions
bmorelli25 5e99ca5
Merge branch 'docs-v2-updates' into 1484-doc-intake-api
bmorelli25 eb5a74b
docs: rework apm overview
bmorelli25 592f15e
docs: more v2
bmorelli25 8312f9a
docs: review improvements and fix compat
bmorelli25 1fed7ab
docs: v2 revisions and fixes
bmorelli25 c212c33
Update example files for official docs. (#2)
simitt a54db05
docs: update structure and config
bmorelli25 97420d3
docs: add redirects file
bmorelli25 dd62bce
docs: fix agent server compat
bmorelli25 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized there are a couple of config options missing in the Configuring APM Server chapter. Some of them were newly introduced, some not. I suggest to check with the
apm-server.ymlfor missing config options (e.g.:apm-server.rum.event_rateandapm-server.rum.source_mapping.elasticsearchshould be added to Set up Real User Monitoring (RUM) support.For
max_event_sizeyou explicitly added that it was introduced with6.5. On one hand it is nice to see newly introduced options, on the other hand it means we have to remove this again for6.6or add the info when an option was introduced everywhere.For everything related to tuning and config options we need some strategy to point out what to tweak and which options to use when agents talk Intake v1 vs. agents talking intake v2, e.g. if somebody uses a ruby agent with intake v1 and a nodejs agent with intake v2, then both - the deprecated and the newly introduced config options - should be set properly.
Not sure how much you want to put into this PR, feel free to create a new issue and defer this.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like
apm-server.rum.source_mapping.elasticsearchwas already added, I've now added inevent_rateas well.configuration-process.asciidocandconfiguration-rum.asciidochave been updated. Changed the order of configuration options to better mirrorapm-server.yml, and added in notes about v1/v2 to hopefully make things clearer.The tuning is a bit more complex, so I've opened #1537