set more config defaults in code #1494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This leaves just |
|
jenkins, retest this please |
simitt
approved these changes
Oct 30, 2018
|
we probably need a change log entry to make people aware.
…On Tue, 30 Oct 2018 at 09.13, Silvia Mitter ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1494 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAC6PyE0EwsxTmuzoh0Mpd7jj_pIhMuks5uqAotgaJpZM4X_2Tv>
.
|
|
Sounds good, I'll add that and get this merged in. |
graphaelli
added a commit
to graphaelli/apm-server
that referenced
this pull request
Oct 31, 2018
graphaelli
added a commit
that referenced
this pull request
Oct 31, 2018
graphaelli
added a commit
to graphaelli/apm-server
that referenced
this pull request
Oct 31, 2018
* set more config defaults in code (elastic#1494) * adapt test for 6.x
graphaelli
added a commit
that referenced
this pull request
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on our discussion of setting defaults in code to match the configuration file. I'm still not sure if this is appropriate for a minor release, happy to discuss.