Add trailing new lines in generated files #1006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphaelli
changed the title
graphaelli
force-pushed
the
approval-newline
branch
from
7e9b6f5 to
f65a4ee
Compare
simitt
approved these changes
Jun 13, 2018
Contributor
simitt
left a comment
simitt
left a comment
There was a problem hiding this comment.
LGTM - just out of curiosity, is there a specific reason for this?
Member
Author
|
no specific reason |
simitt
pushed a commit
to simitt/apm-server
that referenced
this pull request
Jul 4, 2018
* add trailing newline to approvals * add trailing newline to elasticsearch docs
simitt
pushed a commit
to simitt/apm-server
that referenced
this pull request
Jul 4, 2018
* add trailing newline to approvals * add trailing newline to elasticsearch docs
simitt
pushed a commit
that referenced
this pull request
Jul 4, 2018
* add trailing newline to approvals * add trailing newline to elasticsearch docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.