chore: re-add require-in-the-middle dep #3266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was temporarily inlined some releases ago while changes were separately upstreamed. Since then there has been some dev on the module that it would be good to keep up with.
github-actions
bot
added
the
agent-nodejs
Member
Author
|
For the record, the CI was failing for Node.js 12.0 for the https://github.com/elastic/apm-agent-nodejs/pull/3266/commits because it included a git branch dependency, and Node.js 12.0 came with npm v6.9.0 and npm v6.10.0 fixed this error that the such is the pain of supporting ancient releases. |
PeterEinberger
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
It was temporarily inlined some releases ago while changes were separately upstreamed. Since then there has been some dev on the module that it would be good to keep up with. This effectively upgrades from require-in-the-middle v6.0.0 to v7.0.1. https://github.com/elastic/require-in-the-middle/blob/main/CHANGELOG.md#v701
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was temporarily inlined some releases ago while changes were
separately upstreamed. Since then there has been some dev on
the module that it would be good to keep up with.