Skip to content

Conversation

@nitish-egov
Copy link

@nitish-egov nitish-egov commented Oct 16, 2025

Summary by CodeRabbit

  • Infrastructure Improvements
    • Improved tenant data tracking and management capabilities within the building plan approval system by enhancing internal data structures to properly capture, store, and maintain tenant context information throughout the complete application workflow and operations
    • Enhanced system indexing and service operations to better support multi-tenant transaction management scenarios while ensuring improved data consistency, accuracy, and proper tenant isolation across all system workflows

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 16, 2025

Walkthrough

The changes add tenant ID support to the EDCR system by introducing a new tenantId field to the EdcrIndexData entity with accessor methods and populating it from the EdcrApplication object during index data mapping.

Changes

Cohort / File(s) Summary
Tenant ID field addition
online-building-plan-approval-system/edcr/service/egov/egov-edcr/src/main/java/org/egov/edcr/entity/EdcrIndexData.java
Added private tenantId field with public getter getTenantId() and setter setTenantId(String) methods; updated toString() representation to include the new field.
Tenant ID population in mapping
online-building-plan-approval-system/edcr/service/egov/egov-edcr/src/main/java/org/egov/edcr/service/EdcrRestService.java
Added population of tenantId from EdcrApplication into EdcrIndexData within the setEdcrIndexData method when tenantId is non-null.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A tenant ID takes its place,
In index data's growing space,
From app to index, values flow,
Multi-tenant gardens grow! 🌱

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and concisely captures the main change of adding a tenant identifier in the EDCR application without extraneous details. It directly reflects the updates in EdcrIndexData and EdcrRestService that introduce and propagate tenantId. The phrasing is understandable and focused on the developer’s perspective.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch nitish-edcr

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e2d197 and 5ea1607.

📒 Files selected for processing (2)
  • online-building-plan-approval-system/edcr/service/egov/egov-edcr/src/main/java/org/egov/edcr/entity/EdcrIndexData.java (2 hunks)
  • online-building-plan-approval-system/edcr/service/egov/egov-edcr/src/main/java/org/egov/edcr/service/EdcrRestService.java (1 hunks)
🔇 Additional comments (5)
online-building-plan-approval-system/edcr/service/egov/egov-edcr/src/main/java/org/egov/edcr/service/EdcrRestService.java (1)

273-275: LGTM!

The tenantId mapping follows the existing pattern of null-checking before setting fields on EdcrIndexData. The implementation is consistent with other field mappings in this method.

online-building-plan-approval-system/edcr/service/egov/egov-edcr/src/main/java/org/egov/edcr/entity/EdcrIndexData.java (4)

23-23: LGTM!

The field declaration follows Java conventions and is appropriately placed with other EdcrApplication-related fields.


235-241: LGTM!

The getter and setter methods follow standard JavaBean conventions and are correctly implemented.


249-249: LGTM!

The toString() method is correctly updated to include the tenantId field, maintaining consistency with the rest of the implementation.


44-70: Ignore constructor inconsistency concern. The long‐parameter constructor isn’t invoked anywhere—all call sites use the no-arg constructor plus setters (including setTenantId), so no breakage risk.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants