Skip to content

Fixes tree-shaking in css modules #293 #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes tree-shaking in css modules #293 #415

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7edfe9
fix: fixed treeshaking for css modules #293
ch99q Mar 17, 2022
054dec7
fix: fixes tree-shaking in css modules #293
ch99q Mar 17, 2022
9995654
fix: prevented variable name issue
ch99q Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/postcss-loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,29 +191,27 @@ export default {

const cssVariableName = identifier('css', true)
if (shouldExtract) {
output += `export default ${JSON.stringify(modulesExported[this.id])};`
output += `export default ${JSON.stringify(modulesExported[this.id])};`;
extracted = {
id: this.id,
code: result.css,
map: outputMap
}
};
} else {
const module = supportModules ?
JSON.stringify(modulesExported[this.id]) :
cssVariableName
const module = supportModules ? JSON.stringify(modulesExported[this.id]) : cssVariableName;
output +=
`var ${cssVariableName} = ${JSON.stringify(result.css)};\n` +
`export default ${module};\n` +
`export var stylesheet=${JSON.stringify(result.css)};`
`var styleMapping = ${module};\n` +
`export var stylesheet=${JSON.stringify(result.css)};`;
}

if (!shouldExtract && shouldInject) {
output += typeof options.inject === 'function' ? options.inject(cssVariableName, this.id) : '\n' +
`import styleInject from '${styleInjectPath}';\n` +
`styleInject(${cssVariableName}${Object.keys(options.inject).length > 0 ?
`export default /*#__PURE__*/(function() {\n styleInject(${cssVariableName}${Object.keys(options.inject).length > 0 ?
`,${JSON.stringify(options.inject)}` :
''
});`
});\n return styleMapping;\n})();`;
}

return {
Expand Down