-
-
Notifications
You must be signed in to change notification settings - Fork 4
Description
appears to be causing some funky formatting because it isn't including all the correct attributes on inline elements that get broken up by the <ins>/<del> that the diff inserts.
In this example, the original content is a <p> with all its text wrapped in a nested set of <span> elements with inline style attributes. However, in the diff, <ins> elements break up those spans, and only the first set retain the attributes:
I think we just need to take care to preserve the attributes in two spots, but this definitely needs more investigation:
web-monitoring-diff/web_monitoring_diff/html_render_diff.py
Lines 1348 to 1350 in 07b5d1e
| current_content.reverse() | |
| for nested_tag in current_content: | |
| doc.append(f'<{nested_tag}>') |
and:
web-monitoring-diff/web_monitoring_diff/html_render_diff.py
Lines 1626 to 1628 in 07b5d1e
| current_content.reverse() | |
| for nested_tag in current_content: | |
| group.append(f'<{nested_tag}>') |
Metadata
Metadata
Assignees
Labels
Type
Projects
Status

