track: add title and path to output event #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 17916091426Details
💛 - Coveralls |
KokaKiwi
approved these changes
Sep 22, 2025
SachaMorard
reviewed
Sep 22, 2025
| if !edgee_event.context.page.title.is_empty() { | ||
| event.data.page_title_html = Some(edgee_event.context.page.title.clone()); | ||
| event.data.content_title = Some(edgee_event.context.page.title.clone()); | ||
| event.data.page = Some(edgee_event.context.page.title.clone()); |
There was a problem hiding this comment.
@CLEMENTINATOR Are these 3 fields usually set with the Piano JS SDK?
| } | ||
|
|
||
| if !edgee_event.context.page.path.is_empty() { | ||
| event.data.page = Some(data.name.clone()); |
There was a problem hiding this comment.
Same here, does it reproduce the standard JS SDK behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
Describe your changes here
Related Issues
List related issues here