-
Notifications
You must be signed in to change notification settings - Fork 68
feat(graphs): introduce a new multiscale edgebuilding strategy optimizing 1-hop edges #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
| x_hops=x_hops, | ||
| area_mask_builder=nodes.get("_area_mask_builder", None), | ||
| ) | ||
| if new_method: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we think of another name? "new methods" can become "old methods", and it is not a replacement in the sense that it only supports 1 hop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ssmmnn11, totally agree. For now this is just a proof of concept code. It will need some refactor before it can get merged. I'll make it more clear in the PR description.


Description
Building MultiScaleEdges for a Triangular refined Icosahedron with resolution > 8 can become increasingly time consuming.
This PR introduces a new strategy to optimise the creation of 1-hop multiscale edges (
TriNodesEdgeBuilder), relying only on thetrimeshpackage.What problem does this change solve?
What issue or task does this change relate to?
Additional notes
The code is currently still only a proof-of-concept, and will need some refactoring before merging.
Currently implemented:
TriNodes:TriNodesEdgeBuilderStretchedTriNodes:StretchedTriNodesEdgeBuilderLimitedAreaTriNodes:TriNodesEdgeBuilderwitharea_mask_builderAs a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.