-
Notifications
You must be signed in to change notification settings - Fork 67
feat: activate minmium plotting for integration tests #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
VeraChristina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! Everything looks good!
Just wondering if we can reduce test time by not plotting in some of the tests (like restarting training, starting from checkpoint, using an existing graph etc.) where testing the plotting functionality should be covered by the basic training cycle test for the use case
mc4117
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for fixing the issue with the old eda callback!
Description
Testing plots it's not part our current testing suite. Since most of them are implemented via callbacks a simple way would be to activate a minimal plotting set up for the integration test to ensure we don't break them in the future.
This PR proposes those changes:
cc: @VeraChristina - having those tests would also be useful in the context of multiple datasets to ensure there is no feature regression for plotting.
What problem does this change solve?
What issue or task does this change relate to?
Additional notes
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.