-
Notifications
You must be signed in to change notification settings - Fork 67
feat(models): dynamic mappers #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I wonder if we actually need an extra dynamic mapper class. |
As in Simon you mean we could directly refactor the existing mappers so all are dynamic by default? That would significantly reduce the code complexity ... so I like the idea. But it would also mea breaking/not-being to reuse old checkpoints? |
We discussed what would need to be changed. Idea is that mapper should only receive edges, nodes, edge_attr. It will mean breaking things unfortunately. |
|
Refactor planned as described in #552 |
Description
This PR includes some mappers that support dynamic graphs. The main difference is that now the
graphis passed as an argument to theforward()method.What problem does this change solve?
The current mappers set the graph during its creation.
What issue or task does this change relate to?
Additional notes
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.