-
Notifications
You must be signed in to change notification settings - Fork 68
feat(training): autoencoder 🗜️ #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…re into feature/autoencoder
…re into feature/autoencoder
|
@icedoom888 please can you push the branch to this repo too, so we can all run the integration tests. Many thanks. |
|
@mchantry integration tests passing here: https://github.com/ecmwf/anemoi-core/actions/runs/18498383834 |
Great, thanks so much. |
|
@icedoom888 sorry if you have already discussed this. Have you tried using the current forecasting dataset/datamodule but with rollout=0? I believe this will give you the time slices that you get from the singledataset setup, without needing to create a new class. Not adding a new class will help when implementing multiple-datasets for anemoi. |
|
@icedoom888 Can you add a config for the hierarchicalautoencoder, currently I believe there are only exemplar configs for the autoencoder. |
Done! |
|
In this PR there are great plot visualisation changes you've added as mentioned by @mc4117 (https://github.com/ecmwf/anemoi-core/pull/252/files#r2426852227) I've noted the following two aspects:
It seems like this set of changes may be best placed in a second PR. This 2nd PR would have review from some of the primary contributors to the existing plotting logic, there may be useful suggestions for improving it or ensuring it extends to more usecases - currently they only apply to the Callbacks that plot maps. I think outside of this the other plot functions essential for reconstruction plotting can be maintained in this PR |
This code from |
|
@mchantry after changing every single rollout schema to NonNegativeInt to allow for rollout to 0, I now get: This happens because the normal dataset and dataloader are expecting a list of date indeces, not just one. Hence proving the need for my implementation. |
|
@Rilwan-Adewoyin Thanks for reviewing! |
I ran some tests this morning and I think all that would be needed is an if statement where if len(relative_date_indices) == 1 then set time_increment=1 and then this should run? Let me know if this works for you too |
Description
Introduces Autoencoder training in Anemoi.
Type of Change
Issue Number
Closes #171
Reopens #172
Code Compatibility
Code Performance and Testing
Dependencies
Documentation
Additional Notes
📚 Documentation preview 📚: https://anemoi-training--252.org.readthedocs.build/en/252/
📚 Documentation preview 📚: https://anemoi-graphs--252.org.readthedocs.build/en/252/
📚 Documentation preview 📚: https://anemoi-models--252.org.readthedocs.build/en/252/