Skip to content

Conversation

@anaprietonem
Copy link
Contributor

@anaprietonem anaprietonem commented Nov 13, 2025

Description

Testing plots it's not part our current testing suite. Since most of them are implemented via callbacks a simple way would be to activate a minimal plotting set up for the integration test to ensure we don't break them in the future.

This PR proposes those changes:

  • Spectrum plot it's quite slow so for now it's deactivated for the SG model
  • Since the test dataset for LAM and SG is a small one we just test plotting tp
  • The plots for the interpolator are deactivated - while the callbacks run the output produced is not scientifically correct. More work will be done in the future to address this (@mc4117 - notified about this in slack channel)
  • In the hierarchical model - current plotting of edge features is not support - this plot is for now deactivated. (Discussed with @icedoom888 )

cc: @VeraChristina - having those tests would also be useful in the context of multiple datasets to ensure there is no feature regression for plotting.

What problem does this change solve?

What issue or task does this change relate to?

Additional notes

As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/

By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.

@anaprietonem anaprietonem changed the title Plotting integration tests feat: activate minmium plotting for integration tests Nov 13, 2025
@anaprietonem anaprietonem added the ATS Approval Not Needed No approval needed by ATS label Nov 13, 2025
Copy link
Collaborator

@VeraChristina VeraChristina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Everything looks good!

Just wondering if we can reduce test time by not plotting in some of the tests (like restarting training, starting from checkpoint, using an existing graph etc.) where testing the plotting functionality should be covered by the basic training cycle test for the use case

@HCookie HCookie moved this to Under Review in Anemoi-dev Nov 20, 2025
@anaprietonem anaprietonem marked this pull request as ready for review November 21, 2025 11:12
mc4117
mc4117 previously approved these changes Nov 25, 2025
Copy link
Member

@mc4117 mc4117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation bot moved this from Under Review to For merging in Anemoi-dev Nov 25, 2025
Copy link
Member

@mc4117 mc4117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing the issue with the old eda callback!

@anaprietonem anaprietonem merged commit 84e5882 into main Nov 26, 2025
18 checks passed
@anaprietonem anaprietonem deleted the plotting_integration_tests branch November 26, 2025 07:41
@github-project-automation github-project-automation bot moved this from For merging to Done in Anemoi-dev Nov 26, 2025
@DeployDuck DeployDuck mentioned this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants