Clarify how to terminate an http response in the javadoc #5737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI failure doesn't seem related :-/ |
Contributor
Yes it is, no need to call
No worries |
tsegismont
reviewed
Oct 2, 2025
Contributor
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
Thank you @FroMage ! Would you mind adding the comments for sendFile?
FroMage
force-pushed
the
response-terminal-action
branch
from
160584e to
487deb7
Compare
Contributor
Author
|
Sure. |
Member
|
@FroMage can you rebase on latest master, I just fixed a couple of tests failing on Java 25 CI |
FroMage
force-pushed
the
response-terminal-action
branch
from
487deb7 to
9a7fa75
Compare
Contributor
Author
|
Done. |
tsegismont
approved these changes
Oct 3, 2025
Contributor
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
Thank you very much @FroMage !
tsegismont
pushed a commit
that referenced
this pull request
Oct 3, 2025
tsegismont
pushed a commit
that referenced
this pull request
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not clear to us how to signal an error during response processing in Vert.x. One that occurs after we've sent the headers and some chunks of data. Turns out we have to use
reset()but we did not know about this.Hopefully this is now clearer.
Note that I am not sure if
sendFileis also a terminal operation, or if you should callend()after it?See quarkusio/quarkus#50361 (comment)
CC @geoand @tsegismont