[vscode] Add WebviewOptions.enableForms
#11983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the optional `enableForms` field to `WebviewOptions`. This allows the `allow-forms` sandbox attribute to be set. Contributed on behalf of STMicroelectronics
Co-authored-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
added
vscode
vince-fugnitto
approved these changes
Dec 14, 2022
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
LGTM 👍 I confirmed that the changes work as expected, and the API is marked as supported.
Contributor
Author
|
Thank you for the review @vince-fugnitto! Can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Added the optional
enableFormsfield toWebviewOptions.This allows the
allow-formssandbox attribute to be set.Resolves #11517.
Contributed on behalf of STMicroelectronics
How to test
To test you can use the following VSCode extension:
webview-forms-0.0.1.zip
It contributes 6 commands (category:
Test enableForms) that will create a webview with different options set (You can see the options set in the command name and the webview will display them as well).When you opened the webview you can inspect the DevTools to see that the
allow-formssandbox attribute is correctly set (or not set).Review checklist
Reminder for reviewers