ci: replace xvfb action
#11945
Merged
ci: replace xvfb action
#11945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit replaces the deprecated (due to inactivity) action for `xvfb` in favor of using the one provided by default from the latest `ubuntu` runner. Signed-off-by: vince-fugnitto <[email protected]>
marcdumais-work
approved these changes
Dec 5, 2022
Contributor
marcdumais-work
left a comment
marcdumais-work
left a comment
There was a problem hiding this comment.
LGTM - the annotations are gone and CI passes - thanks Vince!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request updates our gh workflow to remove the deprecated
GabrielBB/xvfb-action@v1in favor of the defaultxvfbprovided by theubuntu-latestrunner. The previous action did not seem to be actively maintained, and was using Node 12 which GitHub marked as deprecated.The following annotations should be fixed as a result:
How to test
Review checklist
Reminder for reviewers