Skip to content

Remove extension namespace 'hack' #11931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Remove extension namespace 'hack' #11931

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
354b1d7
Remove hacked-in Extensions namespace
thegecko Nov 29, 2022
dbaa053
Remove ExtensionKind override
thegecko Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions packages/plugin-ext-vscode/src/node/plugin-vscode-init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,19 +47,6 @@ export const doInitialization: BackendInitializationFn = (apiFactory: PluginAPIF
function createVSCodeAPI(apiFactory: PluginAPIFactory, plugin: Plugin): typeof theia {
const vscode = Object.assign(apiFactory(plugin), { ExtensionKind });

// use Theia plugin api to implement vscode extensions api
(<any>vscode).extensions = {
get all(): any[] {
return vscode.plugins.all;
},
getExtension(pluginId: string): any | undefined {
return vscode.plugins.getPlugin(pluginId);
},
get onDidChange(): theia.Event<void> {
return vscode.plugins.onDidChange;
}
};

// override the version for vscode to be a VSCode version
(<any>vscode).version = process.env['VSCODE_API_VERSION'] || VSCODE_DEFAULT_API_VERSION;
return vscode;
Expand Down