Skip to content

Conversation

@colin-grant-work
Copy link
Contributor

What it does

Since #10731, there has been an error logged about missing key properties in a React-rendered div:
image

This PR adds key properties to several divs rendered by the Toolbar, and removes the error log.

How to test

  1. Start the application.
  2. Assert that there are no React errors about missing keys.
  3. Show and hide the Toolbar.
  4. Assert that there are still no React errors about missing keys.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the toolbar issues related to the toolbar label Jun 24, 2022
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@colin-grant-work colin-grant-work merged commit 5f1c74a into eclipse-theia:master Jun 27, 2022
@colin-grant-work colin-grant-work deleted the bugfix/toolbar-react-warning branch June 27, 2022 15:30
@colin-grant-work colin-grant-work added this to the 1.27.0 milestone Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

toolbar issues related to the toolbar

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants