Uplift Monaco to VSCode 1.67.2 #11331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-grant-work
added
monaco
colin-grant-work
force-pushed
the
monaco/uplift-1.67
branch
from
3f93ce8 to
7508e16
Compare
This was referenced Jun 24, 2022
colin-grant-work
force-pushed
the
monaco/uplift-1.67
branch
from
7508e16 to
98597c6
Compare
There was a problem hiding this comment.
I confirmed that functionality the changes work well 👍
- syntax highlighting (verified js, ts, tsx, json, css, html)
- quick-open menus
- outline-view and breadcrumbs
- peek widgets
- debug console
- problem markers are supported
- preferences schemas and validation work
-
autoSaveworks
colin-grant-work
force-pushed
the
monaco/uplift-1.67
branch
from
66e8026 to
f79365e
Compare
vince-fugnitto
approved these changes
Jul 7, 2022
| "onigasm": "^2.2.0", | ||
| "vscode-textmate": "^4.4.0" | ||
| "vscode-oniguruma": "1.6.1", | ||
| "vscode-textmate": "^7.0.1" |
There was a problem hiding this comment.
This will be a nice improvement, with the upgrade we can make use of a timeLimit when tokenizing so we ensure that we do not hang the UI on large tokenizations, and we can adjust our code to not tokenize if a line is too long 👍
There was a problem hiding this comment.
@vince-fugnitto Is this related to the issue brought up in #11391?
There was a problem hiding this comment.
@vince-fugnitto Is this related to the issue brought up in #11391?
Exactly :) I had investigated a little and noticed it was tokenization causing the problem.
1 task
msujew
approved these changes
Jul 11, 2022
added 2 commits
July 12, 2022 15:43
colin-grant-work
force-pushed
the
monaco/uplift-1.67
branch
from
f79365e to
362b539
Compare
colin-grant-work
force-pushed
the
monaco/uplift-1.67
branch
from
362b539 to
34278aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Uplifts
@theia/monaco-editor-coreto the state of [email protected] and makes a few adjustments. In particular, it updates thevscode-textmatedependency to7.0.1to match VSCode in order to provide the accustomed theme experience, and it replacesonigasmwithvscode-onigurumafor the same reason. The former change required some reorganization of code to account for breaking changes invscode-textmate.How to test
Review checklist
Reminder for reviewers