Skip to content

Conversation

@vince-fugnitto
Copy link
Member

What it does

The pull-request includes multiple commits addressing the removal of deprecations present in the framework.
The methods, interfaces, constants and re-exports were deprecated for some time, and a cleanup was in order.

How to test

Confirm that CI passes (both builds and tests).

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

@vince-fugnitto vince-fugnitto added the quality issues related to code and application quality label May 20, 2022
@vince-fugnitto vince-fugnitto force-pushed the vf/low-hanging-deprecations branch from 133a546 to 0837aa2 Compare May 21, 2022 02:45
@colin-grant-work colin-grant-work self-requested a review May 31, 2022 16:41
@vince-fugnitto vince-fugnitto force-pushed the vf/low-hanging-deprecations branch from 0837aa2 to bbdb704 Compare May 31, 2022 18:46
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks to be in order to me. Only one comment.

@vince-fugnitto vince-fugnitto force-pushed the vf/low-hanging-deprecations branch from bbdb704 to 51e201b Compare June 1, 2022 16:39
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The code is cleaner, the tests pass, and the changelog entry appears comprehensive.

@vince-fugnitto vince-fugnitto force-pushed the vf/low-hanging-deprecations branch from 51e201b to e535b95 Compare June 2, 2022 16:08
@vince-fugnitto vince-fugnitto force-pushed the vf/low-hanging-deprecations branch from e535b95 to db4c5a5 Compare June 7, 2022 16:10
@vince-fugnitto
Copy link
Member Author

I'll merge tomorrow if there are no objections.

@vince-fugnitto vince-fugnitto merged commit b3adc5a into master Jun 13, 2022
@vince-fugnitto vince-fugnitto deleted the vf/low-hanging-deprecations branch June 13, 2022 11:44
@github-actions github-actions bot added this to the 1.27.0 milestone Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quality issues related to code and application quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants