yarn upgrade + dep fix

[paul-marechal]

What it does

The pull-request includes the following changes:

• performs a yarn upgrade on the repo, consequently resolving known security vulnerabilities from dependencies.
• sets @electron/remote range to avoid version 2.0.4 as the typings are bogus (fixed upstream but not yet in a patch release).

How to test

• confirm that the repo builds, and the application starts normally
• confirm that the tests pass
• confirm no simple-get vulnerability exists (ex: yarn audit | grep "simple-get")

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto [email protected]

[vince-fugnitto]

I've opened the automatic IP Due Diligence Issues:

• @ampproject/[email protected]
• @babel/core/7.17.2
• @babel/[email protected]
• @babel/[email protected]
• @jest/[email protected]
• @sinonjs/[email protected]
• @types/[email protected]
• @types/[email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]
• [email protected]

[vince-fugnitto]

The dependencies are now approved 👍

[colin-grant-work]

In smoke tests of both browser and Electron applications, everything seemed to be working fine. During the Electron rebuild portion of the build, I did see some compiler warnings that I'm not used to seeing, but the build succeeded and everything looked fine, so I'm not sure whether the output reflects change in dependencies or change in warning behavior of my local native build chain.

Processed "drivelist"
⠙ Building module: drivelist, Completed: 0  CXX(target) Release/obj.target/drivelist/src/drivelist.o
⠼ Building module: drivelist, Completed: 0  CXX(target) Release/obj.target/drivelist/src/device-descriptor.o
⠼ Building module: drivelist, Completed: 0  CXX(target) Release/obj.target/drivelist/src/darwin/list.o
⠹ Building module: drivelist, Completed: 0  CXX(target) Release/obj.target/drivelist/src/darwin/REDiskList.o
⠧ Building module: drivelist, Completed: 0../src/darwin/REDiskList.m:29:13: warning: 'NSArray' may not respond to 'sortUsingSelector:'
    [_disks sortUsingSelector:@selector(localizedCaseInsensitiveCompare:)];
     ~~~~~~ ^
1 warning generated.
⠇ Building module: drivelist, Completed: 0  SOLINK_MODULE(target) Release/drivelist.node
⠸ Building module: find-git-repositories, Completed: 1  CC(target) Release/obj.target/openpa/openpa/src/opa_primitives.o
⠼ Building module: find-git-repositories, Completed: 1  CC(target) Release/obj.target/openpa/openpa/src/opa_queue.o
⠴ Building module: find-git-repositories, Completed: 1  LIBTOOL-STATIC Release/openpa.a
⠇ Building module: find-git-repositories, Completed: 1  CXX(target) Release/obj.target/findGitRepos/src/FindGitRepos.o
⠴ Building module: find-git-repositories, Completed: 1../src/FindGitRepos.cpp:270:28: warning: 'Call' is deprecated [-Wdeprecated-declarations]
  baton->progressCallback->Call(1, argv);
                           ^
../../nan/nan.h:1743:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:108:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
../src/FindGitRepos.cpp:294:13: warning: 'Call' is deprecated [-Wdeprecated-declarations]
  callback->Call(1, argv);
            ^
../../nan/nan.h:1743:3: note: 'Call' has been explicitly marked deprecated here
  NAN_DEPRECATED inline v8::Local<v8::Value>
  ^
../../nan/nan.h:108:40: note: expanded from macro 'NAN_DEPRECATED'
# define NAN_DEPRECATED __attribute__((deprecated))
                                       ^
⠏ Building module: find-git-repositories, Completed: 12 warnings generated.
⠋ Building module: find-git-repositories, Completed: 1  CXX(target) Release/obj.target/findGitRepos/src/Queue.o
⠴ Building module: find-git-repositories, Completed: 1  SOLINK_MODULE(target) Release/findGitRepos.node

Since we recently updated electron-rebuild, that seems the most likely cause.

[colin-grant-work]

Apart from the new warnings from electron-rebuild, which seem to be unrelated to this PR, this looks good to me.