Skip to content

Conversation

@HeikoKlare
Copy link
Contributor

The DnD tests in org.eclipse.ui.tests have effectly been deactivated 12 years ago (probably during E4 transition) by (temporarily) changing to a different test suite:

When switching back to the initial test suite, the DnD tests were disabled for that test suite and never reenabled afterwards:

Currently, the disablement is done by the @Ignore annotation at the ´DragTestSuite`.

The tests are/became incompatible since then. They particularly lack the ability to hook into the drop process that was previously possible with some functionality of the DragUtil class. In addition to these tests not being used for 12 years, they now introduce maintenance issues:

  • They use a JUnit-3-specific setup that is difficult to adapt to JUnit 4/5
  • They are the sole remaining users of an AutoTest fragment including specific test suite and logger implementations that are also still tied to JUnit 3, as well as UITestCase specializations

I do not think that it's worth investing effort into technical maintenance (somehow adapting to JUnit 4/5) without the tests being functional at all. That's why I propose to remove them and create an issue that documents that we don't have such DnD tests anymore with a link to this PR that removed them, such that someone could easily restore the current version of the tests for reviving them, if desired.

@akurtakov @iloveeclipse @vogella asking on this again as it is similiar the unused session tests (#3159) but other than the diverse session tests this affects a complete set of functionality (DnD) which does not seem to be covered by tests at all.

The DnD tests in org.eclipse.ui.tests have been deactivated 12 years ago
and are incompatible since then. They particularly lack the ability to
hook into the drop process that was previously possible with some
functionality of the DragUtil class. In addition to these tests not
being used for 12 years, they now introduce maintenance issues:
- They use a JUnit-3-specific setup that is difficult to adapt to JUnit
4/5
- They are the sole remaining users of an AutoTest fragment including
specific test suite and logger implementations that are also still tied
to JUnit 3, as well as UITestCase specializations
@akurtakov
Copy link
Member

If the number of run tests doesn't decline - this should be ready to do.
No one cared to revive the tests and even if someone does now it would be most likely easier to write new tests than understanding and reviving those.

@github-actions
Copy link
Contributor

Test Results

 2 778 files  ±0   2 778 suites  ±0   1h 44m 27s ⏱️ +31s
 7 933 tests  - 1   7 703 ✅  - 1  229 💤  - 1  1 ❌ +1 
23 340 runs   - 3  22 602 ✅  - 1  737 💤  - 3  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 01b1397. ± Comparison against base commit 30af5e8.

This pull request removes 1 test.
UiTestSuite ‑ TestSuite with 185 tests [example: drag maximized Project Explorer to right of editor area(org.eclipse.ui.tests.dnd.DragTest)]

@HeikoKlare HeikoKlare marked this pull request as ready for review August 14, 2025 10:39
@HeikoKlare
Copy link
Contributor Author

The test bot reports 1 removed test, which is just the ignored test suite:
image

As you can see in the precise results, the number of executed tests is the same, it's just one failure of a test that is know to randomly fail: #294

@akurtakov
Copy link
Member

The test bot reports 1 removed test, which is just the ignored test suite: image

As you can see in the precise results, the number of executed tests is the same, it's just one failure of a test that is know to randomly fail: #294

Seems to be good in this case. Feel free to merge when you consider it done.

@HeikoKlare
Copy link
Contributor Author

As proposed, I have added an issue as a reminder that such tests are missing:

Maybe it could be something for newcomers to dig into how different parts of Platform UI work, which is why I marked it as a "good first issue".

@HeikoKlare HeikoKlare merged commit ee7762a into eclipse-platform:master Aug 14, 2025
16 of 18 checks passed
@HeikoKlare HeikoKlare deleted the remove-dnd-tests branch August 14, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants