Remove long deactivated DnD tests from org.eclipse.ui.tests #3177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


The DnD tests in
org.eclipse.ui.testshave effectly been deactivated 12 years ago (probably during E4 transition) by (temporarily) changing to a different test suite:When switching back to the initial test suite, the DnD tests were disabled for that test suite and never reenabled afterwards:
Currently, the disablement is done by the
@Ignoreannotation at the ´DragTestSuite`.The tests are/became incompatible since then. They particularly lack the ability to hook into the drop process that was previously possible with some functionality of the
DragUtilclass. In addition to these tests not being used for 12 years, they now introduce maintenance issues:I do not think that it's worth investing effort into technical maintenance (somehow adapting to JUnit 4/5) without the tests being functional at all. That's why I propose to remove them and create an issue that documents that we don't have such DnD tests anymore with a link to this PR that removed them, such that someone could easily restore the current version of the tests for reviving them, if desired.
@akurtakov @iloveeclipse @vogella asking on this again as it is similiar the unused session tests (#3159) but other than the diverse session tests this affects a complete set of functionality (DnD) which does not seem to be covered by tests at all.