Skip to content

Add system property to disable beep sounds #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add system property to disable beep sounds #2614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57f8772
Add system property to disable beep sounds
Copilot Oct 10, 2025
f1622e5
Store beep property evaluation in static boolean field and remove tes…
Copilot Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Display.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ enum APPEARANCE {
APPEARANCE appAppearance;
/* System property to be set for SWT application to use the system's theme */
static final String USE_SYSTEM_THEME = "org.eclipse.swt.display.useSystemTheme";
/* System property to control beep sounds */
public static final boolean BEEP_ENABLED = !"off".equalsIgnoreCase(System.getProperty("swt.beep"));

/* Windows and Events */
Event [] eventQueue;
Expand Down Expand Up @@ -671,7 +673,9 @@ public void execute(Runnable runnable) {
*/
public void beep () {
checkDevice ();
OS.NSBeep ();
if (BEEP_ENABLED) {
OS.NSBeep ();
}
}

void cascadeWindow (NSWindow window, NSScreen screen) {
Expand Down
6 changes: 5 additions & 1 deletion bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Display.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,8 @@ public void stop() {

/* Package name */
static final String PACKAGE_PREFIX = "org.eclipse.swt.widgets."; //$NON-NLS-1$
/* System property to control beep sounds */
public static final boolean BEEP_ENABLED = !"off".equalsIgnoreCase(System.getProperty("swt.beep"));
/* This code is intentionally commented.
* ".class" can not be used on CLDC.
*/
Expand Down Expand Up @@ -988,7 +990,9 @@ public void execute(Runnable runnable) {
*/
public void beep () {
if (!isValidThread ()) error (SWT.ERROR_THREAD_INVALID_ACCESS);
GDK.gdk_display_beep(GDK.gdk_display_get_default());
if (BEEP_ENABLED) {
GDK.gdk_display_beep(GDK.gdk_display_get_default());
}
}

long cellDataProc (long tree_column, long cell, long tree_model, long iter, long data) {
Expand Down
6 changes: 5 additions & 1 deletion bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,8 @@ public class Display extends Device implements Executor {
boolean useWsBorderTable = false;
static final String USE_WS_BORDER_TEXT_KEY = "org.eclipse.swt.internal.win32.Text.use_WS_BORDER"; //$NON-NLS-1$
boolean useWsBorderText = false;
/* System property to control beep sounds */
public static final boolean BEEP_ENABLED = !"off".equalsIgnoreCase(System.getProperty("swt.beep"));
/**
* Changes the color of Table header's column delimiters.
* Only affects custom-drawn header, that is when background/foreground header color is set.
Expand Down Expand Up @@ -852,7 +854,9 @@ public void execute(Runnable runnable) {
*/
public void beep () {
checkDevice ();
OS.MessageBeep (OS.MB_OK);
if (BEEP_ENABLED) {
OS.MessageBeep (OS.MB_OK);
}
}

/**
Expand Down
Loading