Fix a bug in eepromDriver for posix #268
Open
+80
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platforms/posix/bsp/bspEepromDriver/include/eeprom/EepromDriver.h
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| EepromDriver::~EepromDriver() { deinit(); } |
Contributor
There was a problem hiding this comment.
Isn't this a questionable asymmetry with virtual init() called directly from the StaticBsp while deinit() is called from this destructor?
Contributor
There was a problem hiding this comment.
I have addressed this, please have a look.
Thank you.
christian-schilling
requested changes
Nov 12, 2025
amit-warbhe
force-pushed
the
cr-136656
branch
3 times, most recently
from
0cb1a38 to
43872f8
Compare
…r closed FD was never closed, added explicit call to cleanup
amit-warbhe
force-pushed
the
cr-136656
branch
from
e7d754f to
2947921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
originates from CR #136656