Move the code action 'Change modifiers to final where possible' to a source action #1547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ource action Signed-off-by: Sheng Chen <[email protected]>
Signed-off-by: Sheng Chen <[email protected]>
fbricon
reviewed
Sep 16, 2020
...ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/GenerateFinalModifiersActionTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sheng Chen <[email protected]>
jdneo
changed the title
fbricon
reviewed
Sep 22, 2020
...clipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/CompletionHandlerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sheng Chen <[email protected]>
Contributor
|
Thanks @jdneo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve redhat-developer/vscode-java#1617
resolve redhat-developer/vscode-java#1379
First half of the gif shows the moved code action
Second half of the gif shows how to leverage the setting
editor.codeActionsOnSaveto add final modifiers on saveSigned-off-by: Sheng Chen [email protected]