Skip to content

feat: Add zh-TW locale #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Add zh-TW locale #537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions docusaurus-search-local/locales/zh-TW.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"theme.SearchBar.label": "搜尋",
"theme.SearchBar.seeAll": "查看全部搜尋結果",
"theme.SearchBar.noResultsText": "沒有找到任何結果",
"theme.SearchBar.searchInContext": "“查看{context}”內的全部結果",
"theme.SearchBar.seeAllOutsideContext": "查看“{context}”以外的全部結果",
Comment on lines +5 to +6
Copy link

@coderabbitai coderabbitai bot Aug 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Fix mistranslation for "searchInContext" and use zh-TW corner quotes.

  • "searchInContext" currently says “查看{context}”內的全部結果, which reads as "view all results" and embeds 查看 inside the quotes. The intent is "Search in {context}".
  • For zh-TW, prefer 「」 corner quotes over English curly quotes.

Apply:

-  "theme.SearchBar.searchInContext": "“查看{context}”內的全部結果",
-  "theme.SearchBar.seeAllOutsideContext": "查看“{context}”以外的全部結果",
+  "theme.SearchBar.searchInContext": "在「{context}」內搜尋",
+  "theme.SearchBar.seeAllOutsideContext": "查看「{context}」以外的全部結果",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"theme.SearchBar.searchInContext": "“查看{context}”內的全部結果",
"theme.SearchBar.seeAllOutsideContext": "查看“{context}”以外的全部結果",
"theme.SearchBar.searchInContext": "在「{context}」內搜尋",
"theme.SearchBar.seeAllOutsideContext": "查看「{context}」以外的全部結果",
🤖 Prompt for AI Agents 
In docusaurus-search-local/locales/zh-TW.json around lines 5-6, the
"searchInContext" string is mistranslated and both strings use English curly
quotes; replace "searchInContext" with a correct zh-TW translation that means
"Search in {context}" (e.g., 在「{context}」中搜尋) and change "seeAllOutsideContext"
to use zh-TW corner quotes and match natural phrasing (e.g.,
在「{context}」以外搜尋全部結果 or 搜尋「{context}」以外的全部結果) so both entries use 「」 and
accurate wording.

Copy link
Author

@mlouielu mlouielu Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply it.

Copy link
Author

@mlouielu mlouielu Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In docusaurus-search-local/locales/zh-TW.json around lines 5-6, the
"searchInContext" string is mistranslated and both strings use English curly
quotes; replace "searchInContext" with a correct zh-TW translation that means
"Search in {context}" (e.g., 在「{context}」中搜尋) and change "seeAllOutsideContext"
to use zh-TW corner quotes and match natural phrasing (e.g.,
在「{context}」以外搜尋全部結果 or 搜尋「{context}」以外的全部結果) so both entries use 「」 and
accurate wording.

Copy link

@coderabbitai coderabbitai bot Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlouielu Perfect! Here are the corrected zh-TW translations you can apply:

  "theme.SearchBar.searchInContext": "在「{context}」內搜尋",
  "theme.SearchBar.seeAllOutsideContext": "查看「{context}」以外的全部結果",

This fixes the mistranslation where "searchInContext" was incorrectly saying "view all results" instead of "search in", and updates both strings to use proper zh-TW corner quotes (「」) instead of English curly quotes.

Thank you for accepting the suggestion to improve the Traditional Chinese translations!

If you found this review helpful, would you consider giving us a shout-out on X?

Thank you for using CodeRabbit!

Copy link

@coderabbitai coderabbitai bot Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlouielu I'll provide the corrected Traditional Chinese translations with proper corner quotes and accurate wording:

  "theme.SearchBar.searchInContext": "在「{context}」內搜尋",
  "theme.SearchBar.seeAllOutsideContext": "查看「{context}」以外的全部結果",

The key changes:

  • "searchInContext": Changed from "查看{context}內的全部結果" (view all results) to "在「{context}」內搜尋" (search within {context}) - this correctly conveys the search action rather than viewing results
  • Quote style: Replaced English curly quotes "" with Traditional Chinese corner quotes 「」 for both strings
  • Natural phrasing: Maintained clear, natural Traditional Chinese expression that users will easily understand

This now properly translates the search functionality labels with appropriate Traditional Chinese typography conventions.

"theme.SearchPage.existingResultsTitle": "“{query}”的搜尋結果",
"theme.SearchPage.emptyResultsTitle": "搜尋文件",
"theme.SearchPage.documentsFound.plurals": "共找到 {count} 篇文件",
"theme.SearchPage.noResultsText": "沒有找到任何結果",
"theme.SearchPage.searchContext.everywhere": "所有"
}