Skip to content

implement workaround for permission error when copying read-only files that have extended attributes set and using Python 3.6 #4642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 19, 2024
Merged

implement workaround for permission error when copying read-only files that have extended attributes set and using Python 3.6 #4642

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4adb577
fix issue when copying read-only files using shutil.copy2
jfgrimm Sep 16, 2024
8cba9e9
log when ignoring permissions error
jfgrimm Sep 16, 2024
55b4c8b
python2 support
jfgrimm Sep 17, 2024
a198ad5
fix import
jfgrimm Sep 17, 2024
5d1f2ce
actually compare file contents in case of permissions error
jfgrimm Sep 17, 2024
df9827d
more explicit python version checking to ignore permissions error
jfgrimm Sep 18, 2024
202ae52
long line
jfgrimm Sep 18, 2024
4a4312e
manually copy xattrs where appropriate
jfgrimm Sep 18, 2024
150d7c3
typo
jfgrimm Sep 18, 2024
a3b26f6
implement test for copy_file to copy read-only file with extended att…
boegel Sep 18, 2024
23b5b78
fix condition in copy_file when hitting PermissionError when copying …
boegel Sep 18, 2024
747eddd
Merge pull request #1 from boegel/read-only-copy2
jfgrimm Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions easybuild/tools/filetools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2435,8 +2435,15 @@ def copy_file(path, target_path, force_in_dry_run=False):
else:
mkdir(os.path.dirname(target_path), parents=True)
if path_exists:
shutil.copy2(path, target_path)
_log.info("%s copied to %s", path, target_path)
try:
# on at least some systems, copying read-only files with shutil.copy2() spits a PermissionError
# but the copy still succeeds
shutil.copy2(path, target_path)
_log.info("%s copied to %s", path, target_path)
except PermissionError as err:
# double-check whether the copy actually succeeded
if not os.path.exists(target_path):
raise EasyBuildError("Failed to copy file %s to %s: %s", path, target_path, err)
elif os.path.islink(path):
if os.path.isdir(target_path):
target_path = os.path.join(target_path, os.path.basename(path))
Expand Down