reuse pre-computed checksums #4569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We calculate MD5 and SHA256 checksums as part of the log output which might take considerable time. Instead of recomputing it in `verify_checksum` we can reuse this value.
boegel
previously requested changes
Jul 3, 2024
Member
boegel
left a comment
boegel
left a comment
There was a problem hiding this comment.
Looks good, tiny request before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We calculate MD5 and SHA256 checksums as part of the log output which might take considerable time.
Instead of recomputing it in
verify_checksumwe can reuse this value.