-
Notifications
You must be signed in to change notification settings - Fork 216
add support for --extra-source-urls to fetch sources from additional URLs
#4079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
boegel
merged 14 commits into
easybuilders:develop
from
joeydumont:source_url_cli_option
Sep 11, 2024
Merged
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e9c8f7b
Add an --extra-source-urls CLI option to fetch sources from additiona…
joeydumont 18a9e29
Addressed review comments.
joeydumont f4ec182
Handle the case build_option('extra_source_urls') is empty in unit te…
joeydumont 281f9ba
extra-sources-url doesn't seem to be configured with init_config, tes…
joeydumont 1f5542e
Moved extra_source_urls to the proper location in BUILD_OPTIONS_CMDLI…
joeydumont d6a8d72
Addressed review comments.
joeydumont 65410ff
Don't have an import alone on its line.
joeydumont 6414ab0
Make houndbot happy.
joeydumont 6d98a2e
Fix the order of imports.
joeydumont dd86456
Address review comments.
joeydumont d454bad
Chose the way that made houndbot happy.
joeydumont 0317785
Need to revert to EASYBUILD_SOURCES_URL in easyblock, importing it fr…
joeydumont 046e0a6
Remove unused import, define variable in two locations.
joeydumont f5fcdb4
Don't repeat definitions.
joeydumont File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -106,8 +106,6 @@ | |||||||
| from easybuild.tools.version import this_is_easybuild, VERBOSE_VERSION, VERSION | ||||||||
|
|
||||||||
|
|
||||||||
| EASYBUILD_SOURCES_URL = 'https://sources.easybuild.io' | ||||||||
boegel marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
|
|
||||||||
| DEFAULT_BIN_LIB_SUBDIRS = ('bin', 'lib', 'lib64') | ||||||||
|
|
||||||||
| MODULE_ONLY_STEPS = [MODULE_STEP, PREPARE_STEP, READY_STEP, POSTITER_STEP, SANITYCHECK_STEP] | ||||||||
|
|
@@ -897,8 +895,11 @@ def obtain_file(self, filename, extension=False, urls=None, download_filename=No | |||||||
| source_urls = [] | ||||||||
| source_urls.extend(self.cfg['source_urls']) | ||||||||
|
|
||||||||
| # add https://sources.easybuild.io as fallback source URL | ||||||||
| source_urls.append(EASYBUILD_SOURCES_URL + '/' + os.path.join(name_letter, location)) | ||||||||
| # Insert --extra-source-urls command line option to the | ||||||||
| # urls to try to download from. | ||||||||
|
||||||||
| # Insert --extra-source-urls command line option to the | |
| # urls to try to download from. | |
| # Add additional URLs as configured |
boegel marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
boegel marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.