fix CI by excluding GC3Pie 2.6.7 (which is broken with Python 2) and improve error reporting for option parsing #3798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
requested changes
Aug 11, 2021
Flamefire
commented
Aug 11, 2021
Contributor
Author
|
Done in the style of #3788 which will likely conflict with this |
boegel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GC3Pie 2.6.7 has a bug which makes it fail to import on Python2 fixed with gc3pie/gc3pie@db82754
Also our error reporting doesn't really help to find this as it just says:
Failed to parse configuration options: invalid syntax (__init__.py, line 2159)which isn't exactly helpfulHence only catch our error