Skip to content

Check for _VERSION and _PREFIX Cray environment variables with both software and module name #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2020
Merged

Check for _VERSION and _PREFIX Cray environment variables with both software and module name #3460

merged 4 commits into from
Oct 25, 2020

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Oct 5, 2020 •
edited
Loading

Cray should include the variables <MODULE_NAME>_VERSION and <MODULE_NAME>_PREFIX in the module. The module name is sometimes different than the software name, so EasyBuild should check for both cases.

@easybuilders easybuilders deleted a comment from boegelbot Oct 14, 2020
@boegel boegel added this to the next release (4.3.1) milestone Oct 14, 2020
@boegel boegel changed the title Check for _VERSION and _PREFIX cray variables with software and module name Check for _VERSION and _PREFIX Cray environment variables with both software and module name Oct 25, 2020
@boegel
clean up also considering environment variables based on module name …
fe8c5c2 
…in probe_external_module_metadata + enhance corresponding test
@easybuilders easybuilders deleted a comment from boegelbot Oct 25, 2020
boegel
boegel approved these changes Oct 25, 2020
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekouts I cleaned this up a bit, and enhanced the tests to cover the use case you're fixing here... Thanks for making the effort to look into the fix yourself!

@boegel boegel merged commit aceb30f into easybuilders:develop Oct 25, 2020
@ekouts
Copy link
Contributor Author

ekouts commented Oct 26, 2020

@boegel Thanks a lot for fixing it!

@ekouts ekouts deleted the cray_variables branch October 26, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.3.1

Development

Successfully merging this pull request may close these issues.

2 participants

@ekouts @boegel