Skip to content

Conversation

@geimer
Copy link
Contributor

@geimer geimer commented Mar 16, 2017

Use module name from naming scheme rather than deriving path from install directory. Fixes #2167 for my use cases.

@boegel I'm not sure about the module symlinking at https://github.com/hpcugent/easybuild-framework/blob/master/easybuild/framework/easyblock.py#L1527, but my gut feeling is that it was broken as well and will be implicitly fixed, too.

@boegel
Copy link
Member

boegel commented Mar 17, 2017

lgtm, but we've learned the hard way not to fix bugs without making sure we have a test that triggers it (to avoid reintroducing the same problem later)

done in geimer#16

@boegel boegel added this to the 3.1.2 milestone Mar 17, 2017
boegel and others added 3 commits March 17, 2017 15:23
@geimer
Copy link
Contributor Author

geimer commented Mar 17, 2017

@boegel I had to fix the unit test you provided in geimer#16 as it was assuming Lua module syntax (hard-coded). Please have quick look at the fix and let me know whether it's OK or whether you have any suggestions for improvement.

@boegel
Copy link
Member

boegel commented Mar 17, 2017

@geimer Oops, I indeed overlooked that even though I made a mental note to fix that before passing it to you, sorry. Fix looks great, thanks!

@boegel
Copy link
Member

boegel commented Mar 17, 2017

Going in, thanks for the bugfix @geimer!

@boegel boegel merged commit 0b1fbb9 into easybuilders:develop Mar 17, 2017
@geimer geimer deleted the fix_modaltsoftname branch March 17, 2017 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants