Skip to content

implement change_dir function in filetools module #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2017
Merged

implement change_dir function in filetools module #2155

merged 3 commits into from
Mar 14, 2017

Conversation

@boegel
Copy link
Member

@boegel boegel commented Mar 9, 2017 •
edited
Loading

change_dir is currently not used in easybuild/tools/run.py, since that would introduce a cyclic dependency between run.py and filetools.py...

@boegel boegel added this to the 3.2.0 milestone Mar 9, 2017
@boegel
Copy link
Member Author

boegel commented Mar 9, 2017

@wpoely86 please review?

This was referenced Mar 9, 2017
Merged
Merged
@boegel boegel modified the milestones: 3.1.2, 3.2.0 Mar 14, 2017
@boegel
Copy link
Member Author

boegel commented Mar 14, 2017

Thanks for the review @wpoely86!

@boegel boegel merged commit ca7fc1e into easybuilders:develop Mar 14, 2017
@boegel boegel deleted the chdir branch March 14, 2017 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpoely86 wpoely86 wpoely86 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.1.2

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @wpoely86