Exclude dependencies of dependencies that extend $MODULEPATH #2152
Conversation
|
Travis failed because of an internal server error downloading Lmod 6.6.3 from github. |
|
@bartoldeman Yes, I'm seeing that download problem for Lmod 6.6.3 pop up in other places too on Travis (which is weird, since it works fine for other Lmod versions...). Clearly unrelated to this PR. :) |
easybuild/framework/easyblock.py
Outdated
| # load modules that open up the module tree before checking deps of deps (in reverse order) | ||
| self.modules_tool.load(excluded_deps[::-1]) | ||
|
|
||
| for dep in excluded_deps: |
There was a problem hiding this comment.
@bartoldeman one tiny suggestion: I would rename dep to excluded_dep here, to avoid confusion...
|
@akesandgren Since you also reported seeing |
|
Yep, new patch works, GCCcore no longer present in the module generated from my ScaLAPACK-2.0.2-intel2017a.eb Nicely done. |
|
Thanks for the fix @bartoldeman, and @akesandgren for the confirmation! |
3 participants
This reintroduces commit 81ec7cc which was partially undone by
commit df69253, including the testcase.
This commit reintroduces the old testcase after the new one with
a different name (test_make_module_dep_of_dep_hmns).