MaSuRCA for foss 2016a #4706
MaSuRCA for foss 2016a #4706
Conversation
| toolchain = {'name': 'foss', 'version': '2016a'} | ||
|
|
||
| buildopts="install-special" | ||
| start_dir="global-1" |
There was a problem hiding this comment.
please move this down, below dependencies
| start_dir="global-1" | ||
|
|
||
| #need a temporary url to download it. Do it manually. | ||
| source_urls = ['http://www.genome.umd.edu/masurca_form.html'] |
There was a problem hiding this comment.
don't specify this via source_urls, but just as a comment, there's no point in letting EasyBuild attempt a download
|
|
||
| sanity_check_paths = { | ||
| 'files': [], | ||
| 'dirs': ["bin"], |
There was a problem hiding this comment.
Maybe make this a bit more specific?
sanity_check_paths = {
'files': ['bin/masurca'],
'dirs': ['include', 'lib'],
}
| ('zlib', '1.2.8'), | ||
| ] | ||
|
|
||
| toolchain = {'name': 'foss', 'version': '2016a'} |
There was a problem hiding this comment.
Sorry if I wasn't clear, this should stay up (above sources) style-wise...
We hope to start automatic style checks soon, including order of parameters.
There was a problem hiding this comment.
Is there a document where the style required to write eb files is specified?
|
Test report by @boegel |
|
@ysagon We have this: http://easybuild.readthedocs.io/en/latest/Contributing.html#code-style-review, but it mostly applies to Python code, i.e. it doesn't formalise desired order of easyconfig parameters. There's been some work on making |
|
lgtm |
|
Test report by @boegel |
|
Going in, thanks @ysagon! |
2 participants
No description provided.